Skip to content

Conversation

@efrainretana
Copy link
Member

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@github-actions github-actions bot added App Configuration Azure.ApplicationModel.Configuration Cognitive - Anomaly Detector Mgmt This issue is related to a management package. Search labels Oct 20, 2025
@efrainretana efrainretana removed Mgmt This issue is related to a management package. App Configuration Azure.ApplicationModel.Configuration Cognitive - Anomaly Detector labels Oct 20, 2025
@github-actions
Copy link

github-actions bot commented Oct 21, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.Search.Documents

@efrainretana efrainretana marked this pull request as ready for review October 28, 2025 22:06
@efrainretana efrainretana requested review from a team as code owners October 28, 2025 22:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR performs a comprehensive renaming from "KnowledgeAgent" to "KnowledgeBase" across the Azure Search Documents SDK, updates the API version from 2025-08-01-preview to 2025-11-01-preview, and introduces new features including metric facets support, web knowledge sources, and enhanced retrieval capabilities.

Key Changes:

  • Rename all "KnowledgeAgent" references to "KnowledgeBase" throughout test utilities, clients, models, and generated code
  • Update service API version from V2025_08_01_Preview to V2025_11_01_Preview
  • Add support for new facet metrics (avg, min, max, cardinality) in search results
  • Introduce new web-based knowledge sources and related models
  • Add elevated read permissions and agentic reasoning capabilities

Reviewed Changes

Copilot reviewed 2 out of 252 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
SearchResources.cs Renamed KnowledgeAgent properties/methods to KnowledgeBase equivalents
KnowledgeBaseModelComparer.cs Renamed class from KnowledgeAgentModelComparer
SearchIndexerClientTests.cs Updated API version references
SearchIndexClientTests.cs Renamed test methods and updated to use KnowledgeBase APIs
SearchClient.cs Added enableElevatedRead parameter, updated documentation from "Cognitive Search" to "AI Search"
SearchClientOptions.cs Updated service version enum and constants
Constants.cs Added new facet metric constants (Avg, Min, Max, Cardinality)
SearchResults.cs Added deserialization support for new facet metrics
FacetType.cs Added new facet type enums
FacetResult.cs Enhanced FacetType logic to support new metrics
KnowledgeBaseRetrievalClient.cs Renamed from KnowledgeAgentRetrievalClient
SearchIndexClient.KnowledgeBases.cs Renamed methods and updated to use KnowledgeBase terminology
Various Generated Models Added new web knowledge source models and serialization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants